One-Click Postage: Don't fallback to main blog on failure#2138
Merged
AprilSylph merged 1 commit intonew-xkit:masterfrom Oct 20, 2023
Merged
One-Click Postage: Don't fallback to main blog on failure#2138AprilSylph merged 1 commit intonew-xkit:masterfrom
AprilSylph merged 1 commit intonew-xkit:masterfrom
Conversation
Author
AprilSylph
approved these changes
Oct 19, 2023
AprilSylph
left a comment
There was a problem hiding this comment.
Code LGTM, and I trust your testing, especially for such a straightforward change.
Up to you whether to wait for @nightpool's review before merging.
nightpool
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This removes a mystifying behavior in which One-Click Postage would, on any failure to post, do its single retry attempt with the target blog changed to the user's main.
This is a common complaint when the post author has the user's sideblog blocked. Silently reblogging to the wrong location in this case makes zero sense.
I'm sure there was a reason for this originally (maybe accessing sideblogs was unreliable?) but I can imagine no case in which the post winding up in the wrong place was a good fallback. If you can't do what the user wants, just fail the action. Simple as that.
(I didn't check if this merge conflicts with #2137, but if it does I'll fix the conflict after either is merged. If it matters, of course—I'm not willing to go out of my way to solicit further discussion.)