Add supportability metrics for auto named apps#2808
Open
kanderson250 wants to merge 1 commit intomainfrom
Open
Add supportability metrics for auto named apps#2808kanderson250 wants to merge 1 commit intomainfrom
kanderson250 wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2808 +/- ##
============================================
+ Coverage 70.31% 70.33% +0.02%
- Complexity 10368 10370 +2
============================================
Files 869 869
Lines 42052 42053 +1
Branches 6396 6396
============================================
+ Hits 29570 29580 +10
+ Misses 9593 9584 -9
Partials 2889 2889 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2793
Simple PR to send up a metric every time an RPMService is registered for a new appName. These metrics will report to the default app to help us identify auto-named apps in the UI.
Eg: auto-named
webapp-123will generate the metricSupportability/AutoAppNaming/ReportingTo/webapp-123in the default app.The default app does not record a metric for its own name. Example below is a screenshot from my test webapp with three servlets.