fix(NcSettingsSection): clear NcAppNavigation toggle overhang#8554
Open
pringelmann wants to merge 1 commit into
Open
fix(NcSettingsSection): clear NcAppNavigation toggle overhang#8554pringelmann wants to merge 1 commit into
pringelmann wants to merge 1 commit into
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8554 +/- ##
=======================================
Coverage 54.60% 54.60%
=======================================
Files 106 106
Lines 3443 3443
Branches 1004 1005 +1
=======================================
Hits 1880 1880
Misses 1322 1322
Partials 241 241 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9 tasks
Contributor
susnux
reviewed
May 20, 2026
| // Clear the NcAppNavigation toggle overhang on the inline-start edge. | ||
| $sectionMarginStart: max( | ||
| #{$sectionMargin}, | ||
| calc(var(--app-navigation-padding) + var(--default-clickable-area) + var(--default-grid-baseline) * 2) |
Contributor
There was a problem hiding this comment.
If we want this then this at least looks a bit uneven to me, most apps I know handle it with:
Suggested change
| calc(var(--app-navigation-padding) + var(--default-clickable-area) + var(--default-grid-baseline) * 2) | |
| calc(2 * var(--app-navigation-padding) + var(--default-clickable-area)) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Resolves
The
NcAppNavigationTogglebutton overlaps the firstNcSettingsSectionheading on Nextcloud settings pages. This PR widen the section's inline-start margin so the heading clears the toggle. Falls back to the existing margin when used without an app navigation.A companion server PR covers the legacy markup and Vue 2 line.
Fix
Widen the inline-start margin using
max(). With anNcAppNavigationpresent, the formula evaluates to ~60 px and clears the toggle. Embedded without a nav, themax()falls back to the existing 28 px and the layout is unchanged.🖼️ Screenshots
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable