Skip to content

fix(NcSettingsSection): clear NcAppNavigation toggle overhang#8554

Open
pringelmann wants to merge 1 commit into
mainfrom
fix/ncsettingssection-toggle-overhang
Open

fix(NcSettingsSection): clear NcAppNavigation toggle overhang#8554
pringelmann wants to merge 1 commit into
mainfrom
fix/ncsettingssection-toggle-overhang

Conversation

@pringelmann
Copy link
Copy Markdown
Contributor

@pringelmann pringelmann commented May 19, 2026

Resolves

The NcAppNavigationToggle button overlaps the first NcSettingsSection heading on Nextcloud settings pages. This PR widen the section's inline-start margin so the heading clears the toggle. Falls back to the existing margin when used without an app navigation.

A companion server PR covers the legacy markup and Vue 2 line.

Fix

Widen the inline-start margin using max(). With an NcAppNavigation present, the formula evaluates to ~60 px and clears the toggle. Embedded without a nav, the max() falls back to the existing 28 px and the layout is unchanged.

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • Check with design if growing left gutter is OK

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann pringelmann self-assigned this May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.60%. Comparing base (26d6db4) to head (d40e003).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8554   +/-   ##
=======================================
  Coverage   54.60%   54.60%           
=======================================
  Files         106      106           
  Lines        3443     3443           
  Branches     1004     1005    +1     
=======================================
  Hits         1880     1880           
  Misses       1322     1322           
  Partials      241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pringelmann pringelmann added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component design Design, UX, interface and interaction design feature: settings Related to the settings component labels May 20, 2026
@pringelmann pringelmann added this to the 8.39.1 milestone May 20, 2026
@pringelmann pringelmann marked this pull request as ready for review May 20, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: app-navigation Related to the app-navigation component feature: settings Related to the settings component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant