Skip to content

build(deps): make vue@3 and vue-router@5 peer dependencies#8156

Draft
ShGKme wants to merge 1 commit into
mainfrom
chore/vue-and-vue-router-as-peer-deps
Draft

build(deps): make vue@3 and vue-router@5 peer dependencies#8156
ShGKme wants to merge 1 commit into
mainfrom
chore/vue-and-vue-router-as-peer-deps

Conversation

@ShGKme
Copy link
Copy Markdown
Contributor

@ShGKme ShGKme commented Feb 3, 2026

☑️ Resolves

  • Alternative for build(deps): allow vue-router ^4.6.4 or ^5.0.2 #8155
  • Makes Vue and Vue-Router required to be on the last major version in apps using the library
  • I'd merge it only after the final Nextcloud 33 release just in case there is a problem with vue-router@5

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme self-assigned this Feb 3, 2026
@ShGKme ShGKme added the dependencies Pull requests that update a dependency file label Feb 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.77%. Comparing base (690b10a) to head (4512199).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8156   +/-   ##
=======================================
  Coverage   52.77%   52.77%           
=======================================
  Files         103      103           
  Lines        3348     3348           
  Branches      977      976    -1     
=======================================
  Hits         1767     1767           
  Misses       1333     1333           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants