-
Notifications
You must be signed in to change notification settings - Fork 0
feat!: bring back stylistic rules #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
susnux
wants to merge
1
commit into
main
Choose a base branch
from
feat/bring-back-stylistic-rules
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /*! | ||
| * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| /** @type {import('stylelint').Config} */ | ||
| module.exports = { | ||
| plugins: ['@stylistic/stylelint-plugin'], | ||
| extends: ['@stylistic/stylelint-config'], | ||
| rules: { | ||
| // overrides to comply with config v3 | ||
| '@stylistic/indentation': 'tab', | ||
| '@stylistic/string-quotes': 'single', | ||
| '@stylistic/selector-list-comma-newline-after': 'always-multi-line', | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| /*! | ||
| * SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| const additionalPseudoSelectors = [ | ||
| // Vue <style scoped> | ||
| // See: https://vuejs.org/api/sfc-css-features.html | ||
| 'deep', | ||
| 'slotted', | ||
|
|
||
| // CSS Modules (including Vue <style module>) | ||
| // See: https://github.com/css-modules/css-modules/blob/master/docs/composition.md#exceptions | ||
| 'global', | ||
| 'local', | ||
| ] | ||
|
|
||
| /** @type {import('stylelint').Config} */ | ||
| module.exports = { | ||
| extends: [ | ||
| 'stylelint-config-recommended-scss', | ||
| 'stylelint-config-recommended-vue/scss', | ||
| ], | ||
| plugins: ['stylelint-use-logical'], | ||
| rules: { | ||
| 'selector-type-no-unknown': null, | ||
| 'rule-empty-line-before': [ | ||
| 'always', | ||
| { | ||
| ignore: ['after-comment', 'inside-block'], | ||
| }, | ||
| ], | ||
| 'declaration-empty-line-before': [ | ||
| 'never', | ||
| { | ||
| ignore: ['after-declaration'], | ||
| }, | ||
| ], | ||
| 'comment-empty-line-before': null, | ||
| 'selector-type-case': null, | ||
| 'no-descending-specificity': null, | ||
| 'selector-pseudo-class-no-unknown': [ | ||
| true, | ||
| { | ||
| ignorePseudoClasses: additionalPseudoSelectors, | ||
| }, | ||
| ], | ||
| 'selector-pseudo-element-no-unknown': [ | ||
| true, | ||
| { | ||
| ignorePseudoElements: additionalPseudoSelectors, | ||
| }, | ||
| ], | ||
|
|
||
| // Disable until we decide if we want "always" or "never" | ||
| 'scss/load-partial-extension': null, | ||
|
|
||
| // Logical properties | ||
| 'csstools/use-logical': [ | ||
| 'always', | ||
| { | ||
| // TODO: make it an error in the next major or large release | ||
| severity: 'warning', | ||
| // Only lint LTR-RTL properties for now | ||
| except: [ | ||
| // Position properties | ||
| 'top', | ||
| 'bottom', | ||
| // Position properties with directional suffixes | ||
| /-top$/, | ||
| /-bottom$/, | ||
| // also for e.g. border-bottom-color | ||
| /-top-/, | ||
| /-bottom-/, | ||
| // Size properties | ||
| 'width', | ||
| 'max-width', | ||
| 'min-width', | ||
| 'height', | ||
| 'max-height', | ||
| 'min-height', | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| overrides: [ | ||
| { | ||
| files: ['*.scss', '**/*.scss'], | ||
| rules: { | ||
| 'at-rule-no-unknown': null, | ||
| 'scss/at-rule-no-unknown': true, | ||
| }, | ||
| }, | ||
| ], | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,99 +1,13 @@ | ||
| /* | ||
| /*! | ||
| * SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| const additionalPseudoSelectors = [ | ||
| // Vue <style scoped> | ||
| // See: https://vuejs.org/api/sfc-css-features.html | ||
| 'deep', | ||
| 'slotted', | ||
|
|
||
| // CSS Modules (including Vue <style module>) | ||
| // See: https://github.com/css-modules/css-modules/blob/master/docs/composition.md#exceptions | ||
| 'global', | ||
| 'local', | ||
| ] | ||
|
|
||
| /** @type {import('stylelint').Config} */ | ||
| module.exports = { | ||
| extends: [ | ||
| 'stylelint-config-recommended-scss', | ||
| 'stylelint-config-recommended-vue/scss' | ||
| './configs/linting.js', | ||
| './configs/formatting.js', | ||
| ], | ||
| ignoreFiles: ['**/*.js', '**/*.ts', '**/*.svg'], | ||
| plugins: ['stylelint-use-logical'], | ||
| rules: { | ||
| // Stylistic rules conflicting with prettier | ||
| 'scss/operator-no-newline-after': null, | ||
| 'scss/operator-no-newline-before': null, | ||
|
|
||
| 'selector-type-no-unknown': null, | ||
| 'rule-empty-line-before': [ | ||
| 'always', | ||
| { | ||
| ignore: ['after-comment', 'inside-block'], | ||
| }, | ||
| ], | ||
| 'declaration-empty-line-before': [ | ||
| 'never', | ||
| { | ||
| ignore: ['after-declaration'], | ||
| }, | ||
| ], | ||
| 'comment-empty-line-before': null, | ||
| 'selector-type-case': null, | ||
| 'no-descending-specificity': null, | ||
| 'selector-pseudo-class-no-unknown': [ | ||
| true, | ||
| { | ||
| ignorePseudoClasses: additionalPseudoSelectors, | ||
| }, | ||
| ], | ||
| 'selector-pseudo-element-no-unknown': [ | ||
| true, | ||
| { | ||
| ignorePseudoElements: additionalPseudoSelectors, | ||
| }, | ||
| ], | ||
|
|
||
| // Disable until we decide if we want "always" or "never" | ||
| 'scss/load-partial-extension': null, | ||
|
|
||
| // Logical properties | ||
| 'csstools/use-logical': [ | ||
| 'always', | ||
| { | ||
| // TODO: make it an error in the next major or large release | ||
| severity: 'warning', | ||
| // Only lint LTR-RTL properties for now | ||
| except: [ | ||
| // Position properties | ||
| 'top', | ||
| 'bottom', | ||
| // Position properties with directional suffixes | ||
| /-top$/, | ||
| /-bottom$/, | ||
| // also for e.g. border-bottom-color | ||
| /-top-/, | ||
| /-bottom-/, | ||
| // Size properties | ||
| 'width', | ||
| 'max-width', | ||
| 'min-width', | ||
| 'height', | ||
| 'max-height', | ||
| 'min-height', | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| overrides: [ | ||
| { | ||
| files: ['*.scss', '**/*.scss'], | ||
| rules: { | ||
| 'at-rule-no-unknown': null, | ||
| 'scss/at-rule-no-unknown': true, | ||
| }, | ||
| }, | ||
| ], | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.