Skip to content

fix(auto-upload): handle upload results #16371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alperozturk96 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(auto-upload): handle upload results #16371

alperozturk96 wants to merge 5 commits into from
+75 −35

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jan 26, 2026 •
edited
Loading

  • Tests written, or not not needed

Issue: #16348

@alperozturk96
fix(auto-upload): handle uploaded files
bdd34b9 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix(auto-upload): handle upload results
3312361 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/handle-auto-upload-results branch from ec726ea to 3312361 Compare January 26, 2026 13:10
@alperozturk96 alperozturk96 mentioned this pull request Jan 26, 2026
Open
4 tasks
@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Jan 26, 2026

/backport to stable-3.35

@alperozturk96
fix(auto-upload): handle upload results
f96b4fd 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix(auto-upload): handle upload results
bae2f98 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix(auto-upload): handle upload results
9e047e3 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
alperozturk96 commented Jan 26, 2026
View reviewed changes
app/src/main/java/com/nextcloud/utils/extensions/UploadResultExtensions.kt
UploadResult.VIRUS_DETECTED,
UploadResult.QUOTA_EXCEEDED,
UploadResult.SAME_FILE_CONFLICT,
UploadResult.PRIVILEGES_ERROR,
Copy link
Collaborator Author

@alperozturk96 alperozturk96 Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UploadResult.PRIVILEGES_ERROR, UploadResult.CREDENTIAL_ERROR, UploadResult.LOCAL_STORAGE_NOT_COPIED, I'm not sure about these lets decide together. @tobiasKaminsky

@github-actions
Copy link

github-actions bot commented Jan 26, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code256256
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4343
Security1818
Total479479

@github-actions
Copy link

github-actions bot commented Jan 26, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16371.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Jan 26, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review backport-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96