feat(admin-controller): add route to fetch all circles#2614
Open
cristianscheid wants to merge 1 commit into
Open
feat(admin-controller): add route to fetch all circles#2614cristianscheid wants to merge 1 commit into
cristianscheid wants to merge 1 commit into
Conversation
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
53a5dd6 to
18e4e37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing admin endpoint for fetching circles requires an emulated user:
ocs/v2.php/apps/circles/admin/{emulated}/circlesResults are scoped to the emulated user, so only circles related to that specific user are returned.
This PR introduces a new admin endpoint that returns all circles from the instance without user scoping:
ocs/v2.php/apps/circles/admin/circlesallThe authenticated admin user is used for auth only, not to scope results:
Params available:
The filter params are related to those configs (defined on lib/Model/Circle):
All filter params default to
true(1). So to include, for example, personal circles in the results, you must explicitly pass?filterPersonal=0to disable the filter.Below are some request examples:
Checklist
3. to review, feature component)stable32)AI (if applicable)