Skip to content

fix(PagePicker): pass title from smart picker to text #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mejo- wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Draft

fix(PagePicker): pass title from smart picker to text #2522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/composables/useEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import { t } from '@nextcloud/l10n'
import debounce from 'debounce'
import { computed, defineCustomElement, markRaw, nextTick, onBeforeUnmount, ref, watch } from 'vue'
import { getLinkWithPicker } from '@nextcloud/vue/components/NcRichText'
import { getReferenceWithPicker } from '@nextcloud/vue/components/NcRichText'

Check failure on line 12 in src/composables/useEditor.ts

View workflow job for this annotation

GitHub Actions / NPM lint 

Module '"@nextcloud/vue/components/NcRichText"' has no exported member 'getReferenceWithPicker'. Did you mean to use 'import getReferenceWithPicker from "@nextcloud/vue/components/NcRichText"' instead?
import PageIcon from '../components/Icon/PageIcon.vue'
import { useCirclesStore } from '../stores/circles.js'
import { useCollectivesStore } from '../stores/collectives.js'
Expand Down Expand Up @@ -107,7 +107,7 @@
label: t('collectives', 'Link to page'),
icon: 'page-icon',
action: () => {
return getLinkWithPicker('collectives-ref-pages', false)
return getReferenceWithPicker('collectives-ref-pages', false)
},
},
openLinkHandler: window.OCA.Collectives.openLink,
Expand Down
6 changes: 5 additions & 1 deletion src/views/PagePicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,13 @@ export default defineComponent({
+ generateUrl('/apps/collectives')
+ collectivePath
+ '/' + pagePath
const detail = {
link: pageLink,
title: page.title,
}
this.$el.dispatchEvent(new CustomEvent('submit', {
bubbles: true,
detail: pageLink,
detail,
}))
} else {
console.error('Cannot generate page link')
Expand Down
Loading