Skip to content

Add psalm workflow#175

Open
come-nc wants to merge 3 commits into
masterfrom
enh/add-psalm-workflow
Open

Add psalm workflow#175
come-nc wants to merge 3 commits into
masterfrom
enh/add-psalm-workflow

Conversation

@come-nc

@come-nc come-nc commented Jun 9, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@come-nc come-nc self-assigned this Jun 9, 2022
@come-nc come-nc requested a review from ArtificialOwl June 9, 2022 15:03
@come-nc

come-nc commented Jun 9, 2022

Copy link
Copy Markdown
Contributor Author

Lots of OC\ usage, if they are not removable we should stub them.

This one seem like a valid concern:

ERROR: InvalidPropertyAssignmentValue - lib/Provider/FilesProvider.php:94:26 - $this->indexOptions with declared type 'OCP\FullTextSearch\Model\IIndexOptions' cannot be assigned type 'array<empty, empty>' (see https://psalm.dev/145)
61
	private $indexOptions = [];

The property is indeed passed to methods which only accepts an IIndexOptions instance.

@come-nc

come-nc commented Sep 29, 2022

Copy link
Copy Markdown
Contributor Author

/rebase

1 similar comment
@come-nc

come-nc commented Sep 30, 2022

Copy link
Copy Markdown
Contributor Author

/rebase

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the enh/add-psalm-workflow branch from 75bd7e6 to d2f4530 Compare September 30, 2022 12:58
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc removed their assignment Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant