Skip to content

feat(OCP): Add Interaction API#61128

Merged
provokateurin merged 4 commits into
masterfrom
feat/ocp/interaction
Jul 7, 2026
Merged

feat(OCP): Add Interaction API#61128
provokateurin merged 4 commits into
masterfrom
feat/ocp/interaction

Conversation

@provokateurin

@provokateurin provokateurin commented Jun 10, 2026

Copy link
Copy Markdown
Member

Needed for Governance and Unified Sharing and to centralize existing share restrictions.

@provokateurin provokateurin added this to the Nextcloud 35 milestone Jun 10, 2026
@provokateurin provokateurin requested a review from a team as a code owner June 10, 2026 05:13
@provokateurin provokateurin removed the request for review from a team June 10, 2026 05:13
@provokateurin provokateurin added the 3. to review Waiting for reviews label Jun 10, 2026
@provokateurin provokateurin force-pushed the feat/ocp/interaction branch from 0a0a96a to a5232ac Compare June 10, 2026 07:17
salmart-dev
salmart-dev previously approved these changes Jun 10, 2026
@provokateurin

Copy link
Copy Markdown
Member Author

I'll add some implementations in this PR.

@provokateurin provokateurin marked this pull request as draft June 10, 2026 08:54
@provokateurin provokateurin added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jun 10, 2026
Comment thread lib/public/Interaction/InteractionResource.php
@provokateurin provokateurin force-pushed the feat/ocp/interaction branch from a5232ac to 5494f52 Compare June 30, 2026 14:01
@provokateurin provokateurin marked this pull request as ready for review June 30, 2026 14:01
@provokateurin provokateurin dismissed salmart-dev’s stale review June 30, 2026 14:04

Implementations were added.

Comment thread apps/files/lib/Listener/RestrictInteractionListener.php Outdated
Comment thread apps/files_sharing/lib/Listener/RestrictInteractionListener.php Outdated
Comment thread core/Listener/RestrictInteractionListener.php
Comment thread lib/public/Interaction/Actions/ShareAction.php

@salmart-dev salmart-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things only

Comment thread lib/public/Interaction/Resources/NodeResource.php
Comment thread lib/public/Interaction/Resources/NodeResource.php Outdated
@provokateurin provokateurin added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 1, 2026
@provokateurin provokateurin force-pushed the feat/ocp/interaction branch from 5494f52 to f28cfed Compare July 1, 2026 06:35
Comment thread lib/public/Interaction/Resources/NodeResource.php
@provokateurin provokateurin force-pushed the feat/ocp/interaction branch from f28cfed to 516ea14 Compare July 1, 2026 13:15
@provokateurin

Copy link
Copy Markdown
Member Author

Added one missing restriction and migrated files_sharing to use the new API. You can cross reference the restrictions from commit 2 and 3, to check that none went missing and they are correctly implemented.

@provokateurin

Copy link
Copy Markdown
Member Author

All failing tests should be fixed now. The manager tests needed a lot of changes, because some were only testing some internal methods and now they're calling a lot more.

@provokateurin provokateurin force-pushed the feat/ocp/interaction branch from 32ad7da to a44c028 Compare July 6, 2026 14:27
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
…sed parameter

Signed-off-by: provokateurin <kate@provokateurin.de>
…tions

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the feat/ocp/interaction branch from a44c028 to fb17121 Compare July 7, 2026 06:20
@provokateurin provokateurin merged commit ed052e6 into master Jul 7, 2026
235 of 245 checks passed
@provokateurin provokateurin deleted the feat/ocp/interaction branch July 7, 2026 10:42
@provokateurin

Copy link
Copy Markdown
Member Author

/backport to stable34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement pending documentation This pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants