chore(e2e): Replace deprecated buildjet with native github cache#61894
Open
DerDreschner wants to merge 1 commit into
Open
chore(e2e): Replace deprecated buildjet with native github cache#61894DerDreschner wants to merge 1 commit into
DerDreschner wants to merge 1 commit into
Conversation
DerDreschner
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
salmart-dev
and removed request for
a team
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
DerDreschner
changed the title
DerDreschner
force-pushed
the
chore/remove-buildjet
branch
9 times, most recently
from
e35ac18 to
fb11efe
Compare
Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
DerDreschner
force-pushed
the
chore/remove-buildjet
branch
from
fb11efe to
9bca81f
Compare
Member
That mechanism was build in the last months and tested with Talk and some other apps. |
Contributor
Author
Uhh, that's nice!! Thanks for letting me know! |
| echo ' 1. Extract the folder from the zip file' | ||
| echo ' 2. run "npx playwright show-report name-of-my-extracted-playwright-report"' | ||
| - name: Delete context on success |
Member
There was a problem hiding this comment.
should be in the summary? so other restarts would still have it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cypress and playwright workflows use buildjet for caching. This service isn't being maintained anymore for GitHub Actions (see https://buildjet.com/for-github-actions/blog/we-are-shutting-down ). It works for the moment, but having in mind that it's being officially shut down end of March... It's only a matter of time until our e2e tests will fall apart if we keep using it.
Keep in mind that this change was made in the template repository months ago and could have been synced automatically, if the used workflows here wouldn't have diverged quite a bit from the templates. It wouldn't be bad if we could bring those together again or at least have a mechanism to add modifications to workflows during the sync process.
As the scope of GitHub caches are limited to the own branch and their parents (e.g., master), it might make sense to run it on master and stable branches regularly to keep a suitable cached copy for more runs. That would be an equivalent strategy like we do for CodeQL (this workflow file is creating all those
codeql-overlay-base-databasecaches listed here).Checklist
3. to review, feature component)stable32)AI (if applicable)