fix(caldav): url-encode owner/user in activity event links#61973
Open
Otto-Deviant1904 wants to merge 1 commit into
Open
fix(caldav): url-encode owner/user in activity event links#61973Otto-Deviant1904 wants to merge 1 commit into
Otto-Deviant1904 wants to merge 1 commit into
Conversation
Otto-Deviant1904
requested review from
ChristophWurst,
SebastianKrupinski and
tcitworld
as code owners
Activity links break when a uid has a space, since owner/affectedUser weren't url-encoded the way calendar_uri already is. Wrapped both in rawurlencode(), same fix joshtrichards okayed on the issue. Added two test cases for uids with spaces and confirmed they fail without the fix. Fixes nextcloud#61738 Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: OttoDev <f20240223@goa.bits-pilani.ac.in>
Otto-Deviant1904
force-pushed
the
fix/caldav-activity-uid-space-encoding
branch
from
65f100b to
2da2c93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61738.
Activity links break when a uid has a space, since owner/affectedUser weren't url-encoded the way calendar_uri already is. Wrapped both in rawurlencode(), same fix @joshtrichards okayed on the issue.
Added two test cases for uids with spaces and confirmed they fail without the fix, pass with it. Ran the full EventTest suite locally (13 tests, 55 assertions, all passing).
Assisted with Claude Code.