fix(UserPlugin): Don't return mail matches on user id search#61981
Open
DerDreschner wants to merge 1 commit into
Open
fix(UserPlugin): Don't return mail matches on user id search#61981DerDreschner wants to merge 1 commit into
DerDreschner wants to merge 1 commit into
Conversation
DerDreschner
requested review from
ArtificialOwl,
leftybournes and
provokateurin
and removed request for
a team
8 tasks
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable34 |
DerDreschner
force-pushed
the
fix/respect-full-match-mail-in-edge-cases
branch
from
ab377f6 to
70e10a5
Compare
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
DerDreschner
force-pushed
the
fix/respect-full-match-mail-in-edge-cases
branch
from
70e10a5 to
4b50b87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #47686 , the backend search not only returns matches by user ID, but also by their mail address. This is very confusing, as you would expect that to be impossible when the
shareapi_restrict_user_enumeration_full_match_emailsetting is being set tono.This PR fixes that by checking if the matched user in the user ID code branch was actually a match by user ID and not by something else (like the mail address) as well as adding integration tests to prevent that from happening in the future.
Checklist
3. to review, feature component)stable32)AI (if applicable)