feat(ITeamManager): Add getTeam method#62038
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
ArtificialOwl,
icewind1991 and
leftybournes
and removed request for
a team
|
Rector CI is only failing due to #62034, so it can be ignored. |
| } | ||
|
|
||
| if ($userId !== null) { | ||
| $this->circlesManager->startSession($this->circlesManager->getLocalFederatedUser($userId)); |
There was a problem hiding this comment.
other places on this class use $this->circlesManager->getFederatedUser() to start session for a user, shouldn't we use the same here?
There was a problem hiding this comment.
Not entirely sure, but those methods could potentially use a remote user, right? From my perspective the userid parameters in this class are only meant to be used with local users. But again, I'm not really sure.
There was a problem hiding this comment.
looking at lib/CirclesManager, what getLocalFederatedUser() does is call getFederatedUser($userId, Member::TYPE_USER), so basically you are achieving the same as other places in this class who call getFederatedUser() directly
for reference:
lib/CirclesManager::getFederatedUser()
lib/CirclesManager::getLocalFederatedUser()
| } | ||
|
|
||
| if ($userId !== null) { | ||
| $this->circlesManager->startSession($this->circlesManager->getLocalFederatedUser($userId)); |
There was a problem hiding this comment.
looking at lib/CirclesManager, what getLocalFederatedUser() does is call getFederatedUser($userId, Member::TYPE_USER), so basically you are achieving the same as other places in this class who call getFederatedUser() directly
for reference:
lib/CirclesManager::getFederatedUser()
lib/CirclesManager::getLocalFederatedUser()
3 participants
Needed for #51803.