feat: extract gateway frontend lib module under src#1078
Open
vitormattos wants to merge 31 commits into
Open
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…nfig Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
… config Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…st config Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ypes Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…iewModel Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ceModalModel Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…dex.ts Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…DME.md Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ewayInstanceCard Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…way in GatewayInstanceModal Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…y in GatewayTestModal Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ewayRoutingModal Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…y in GatewaySection Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…-gateway in AdminSettings Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…tModal.spec Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ctor-gateway Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Remove brittle DOM wrapper existence assertion - Validate sanitization directly via computed property (sanitizedWizardQrSvg) - Use conditional DOM check as secondary validation when element exists - Fixes flaky Signal test; all 97 tests now passing consistently Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
feat/phase2-package-workspace-foundation
branch
2 times, most recently
from
1c3826a to
70aec78
Compare
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the gateway frontend logic into a dedicated internal module (
src/lib/twofactor-gateway) instead of fragmenting it into a separate top-levelpackages/folder.What changed
New:
src/lib/twofactor-gateway/Internal module with full source of truth for:
FieldDefinition,GatewayInfo,GatewayInstance,GatewayGroup,GatewayProviderDefinition,TestResult,InteractiveSetupResponseadminGatewayApi,adminGatewayViewModel,gatewayInstanceModalModeluseGatewayApi,useGatewayFormAccessed via the
@lib/twofactor-gatewaypath alias (defined intsconfig.json,vite.config.ts, andvitest.config.js).Updated:
src/services/(compat layer)adminGatewayTypes,adminGatewayApi,adminGatewayViewModel,gatewayInstanceModalModelnow re-export from@lib/twofactor-gateway. Existing consumers (views, components, tests) require no changes.Why this approach
src/— no fragmentation