Skip to content

Fix NPE related to missing a title for initialization #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
austinv11 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Fix NPE related to missing a title for initialization #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/nextflow/lsp/NextflowLanguageServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ private boolean shouldInitialize(LanguageServerConfiguration previous, LanguageS
private void initializeWorkspaces() {
var progress = new ProgressNotification(client, "initialize");
progress.create();
progress.begin("Initializing workspace...");
progress.begin("Initializing", "Initializing workspace...");

var count = 0;
var total = workspaceRoots.keySet().size() - 1;
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/nextflow/lsp/util/ProgressNotification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@ public void create() {
client.createProgress(new WorkDoneProgressCreateParams(Either.forLeft(token)));
}

public void begin(String message) {
public void begin(String title, String message) {
var progress = new WorkDoneProgressBegin();
progress.setTitle(title);
progress.setMessage(message);
progress.setPercentage(0);
client.notifyProgress(new ProgressParams(Either.forLeft(token), Either.forLeft(progress)));
Expand Down