Address Netty CVEs by bumping AWS SDK and excluding micronaut-core-bom from test classpath#7100
Merged
pditommaso merged 8 commits intomasterfrom May 7, 2026
Merged
Conversation
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
pditommaso
reviewed
May 6, 2026
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
pditommaso
reviewed
May 6, 2026
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
pditommaso
reviewed
May 6, 2026
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Jorge Ejarque <jorgee@users.noreply.github.com>
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
Contributor
Author
|
Solved conflicts with master bumping AWS 2.44.3 that includes netty 4.1.133.Final in their POMS. Azure does not have a version with the latest patched Netty version yet. However the azure bump updates to 4.1.132.Final which fixes some Netty issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address two HIGH-severity Dependabot alerts on transitively-pulled Netty:
netty-codec-httpHTTP Request Smuggling (alerts #155, #156)netty-codec-http2CONTINUATION Frame Flood DoS (alerts #157, #158)Rather than pinning Netty versions explicitly, this PR fixes the root causes of how the vulnerable Netty was reaching Nextflow:
nf-amazon(2.33.2 → 2.44.3),nf-codecommit(2.31.64 → 2.44.3). This SDK version already pull patched Netty 4.1.133.Final natively in their POMs.The Azure SDK in
nf-azure(azure-storage-blob12.33.2 → 12.33.3,azure-identity1.18.2 → 1.18.3). The newer SDKs already pull patched Netty 4.1.132.Final natively in their POMs.io.micronaut:micronaut-core-bomfromtestRuntimeClasspathin the three plugins. That BOM (transitively reached throughtestImplementation project(':nextflow')→npr-api→micronaut-serde-api) was declaring a constraint forcing Netty to 4.2.5.Final on the test classpath only — overriding whatever the AWS / Azure SDKs ship and re-introducing the vulnerable line. The exclusion lets the test classpath inherit the same Netty as runtime.nf-tower: bumped WireMock 3.13.1 → 3.13.2 (latest patch; ships Jetty 11.0.26).Why this is better than version pinning
testRuntimeClasspath.excludeper plugin replaces a five-lineconstraints { strictly … }block.Other changes
plugins/nf-amazon/src/main/nextflow/cloud/aws/nio/S3Client.java: explicitimport java.nio.file.AccessDeniedException;added. AWS SDK 2.42.41 introducessoftware.amazon.awssdk.services.s3.model.AccessDeniedException; the wildcard imports for both packages now collide, so an explicit import is required to disambiguate to the JDK type.Verification
Same checks pass for
nf-azureandnf-codecommit.Remaining Dependabot alerts (no code fix available)
To be dismissed via the GitHub UI /
gh api— not reachable from any published Nextflow artifact:shadow-gradle-plugin) ; verified absent from every resolved classpath in every module/plugin × every configuration.shadow-gradle-plugin.Test plan
./gradlew :plugins:nf-amazon:test :plugins:nf-azure:test :plugins:nf-codecommit:test --rerun-tasks— all pass:dependencies --configuration {runtime,test}Classpathshows Netty resolves to 4.1.132.Final cleanly across all three plugins🤖 Generated with Claude Code