Skip to content

Template update 3.5.2#103

Merged
nictru merged 7 commits intodevfrom
template-update-3.5.2
Feb 22, 2026
Merged

Template update 3.5.2#103
nictru merged 7 commits intodevfrom
template-update-3.5.2

Conversation

@nictru
Copy link
Copy Markdown
Collaborator

@nictru nictru commented Feb 15, 2026

This also switches to the nf-core github runners, as using them is part of the nf-core template. Partly replaces #101

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 15, 2026

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d4fc618

+| ✅ 359 tests passed       |+
#| ❔   1 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗  16 tests had warnings |!
Details

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in README.md: If applicable, make list of people who have also contributed
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in README.md: Add bibliography of tools and data used in your pipeline
  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.2
  • Run at 2026-02-20 16:36:53

Copy link
Copy Markdown
Collaborator

@LuisHeinzlmeier LuisHeinzlmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only noticed the difference in the capitalization of Channel. Other than that, LGTM. Thank you @nictru!

Comment thread workflows/hadge.nf
Comment thread workflows/hadge.nf
@nictru nictru enabled auto-merge (squash) February 20, 2026 13:24
@LuisHeinzlmeier
Copy link
Copy Markdown
Collaborator

LuisHeinzlmeier commented Feb 20, 2026

Changed all uppercase Channels to lowercase channels (except for nf-core modules).

@nictru
Copy link
Copy Markdown
Collaborator Author

nictru commented Feb 20, 2026

You can change your review to merge it, I can't approve my own PR

@LuisHeinzlmeier LuisHeinzlmeier self-requested a review February 22, 2026 11:07
@nictru nictru merged commit 067f0a1 into dev Feb 22, 2026
14 checks passed
@nictru nictru deleted the template-update-3.5.2 branch February 22, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants