Skip to content

update test full profile#290

Merged
atrigila merged 1 commit into
nf-core:devfrom
atrigila:update_full_test
Jun 5, 2026
Merged

update test full profile#290
atrigila merged 1 commit into
nf-core:devfrom
atrigila:update_full_test

Conversation

@atrigila
Copy link
Copy Markdown
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phaseimpute branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@atrigila atrigila requested a review from LouisLeNezet May 19, 2026 19:37
Copy link
Copy Markdown
Collaborator

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this modification.
Stitch and quilt are quite slow.
This will increase quite a lot the credit consumption on seqera.
Do we really need it ?

@atrigila
Copy link
Copy Markdown
Collaborator Author

We can inspect results, and if they are slow, then we have an opportunity to improve how inputs are processed when reaching these tools. Sarek launches even different tests with different tools on cloud: https://github.com/nf-core/sarek/blob/master/.github/workflows/cloudtest.yml. I can ask core or the community how they handle this so we can be sure :)

@LouisLeNezet
Copy link
Copy Markdown
Collaborator

I can ask core or the community how they handle this so we can be sure :)

If we could have someone experienced with big test to help us this would be great.
I never worked on cloud environment, and I don't want our test to be too expensive.

Copy link
Copy Markdown
Collaborator

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can monitor it and stop it before it cost too much, it's all good for me.
I agree it would be nice to have a test with all the tools !

@atrigila atrigila merged commit fa9fac8 into nf-core:dev Jun 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants