fix: filter HEARTBEAT_OK and NO_REPLY sentinel messages from chat UI#24
Merged
Conversation
Adds rendering-layer filtering so agent sentinel responses (HEARTBEAT_OK, NO_REPLY) are hidden from the message list. Raw data is preserved in the hook and cache — only the visual rendering is affected. - New isSentinelMessage() utility in src/lib/sentinel.ts - ChatView filters messages via useMemo before rendering - Unit tests for sentinel detection (7 cases) Closes #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filters agent sentinel responses (
HEARTBEAT_OK,NO_REPLY) from the ClawChat message list. These are internal protocol signals — not meaningful conversation — and showing them as chat bubbles is noisy and confusing.Implementation
src/lib/sentinel.ts—isSentinelMessage()utility that checks if trimmed text exactly matches a known sentinel. Uses aSetfor O(1) lookup and is easily extensible for future blocklist entries.src/components/ChatView.tsx— Filters messages viauseMemobefore rendering. Raw data is preserved in the hook/cache (filtering happens at the rendering layer per the issue spec).src/test/sentinel.test.ts— 7 unit tests covering exact match, whitespace trimming, partial matches, case sensitivity, and null/empty handling.Acceptance Criteria
HEARTBEAT_OKmessages do not appear in the chat UINO_REPLYmessages do not appear in the chat UICloses #21