SCPIInstrument API to list driver supported models and transports #1059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andrew,
This PR is an extension of SCPIInstrument API used to provide information about models supported by the driver and accepted transports.
AddInstrumentDialog (PR to come once ngscopeclient/scopehal-apps#951 has been merged) relies on this API to pre-fill transport combo, path string and nickname:
Driver may add a static GetDriverSupportedModels() to list supported model names and their associated transport / connection string template.
If they do, this list will be used in AddInstrumentDialog to limit the list of available transports and to pre-fill nickname and connection string.
If they don't, the behavior of the AddInstrumentDialog remains unchanged.
If a driver lists more than one model, a model combo is added to the dialog.