Skip to content

fix: use seed48() for complete RNG state initialization #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nh13 merged 1 commit into from
Dec 26, 2025
Merged

fix: use seed48() for complete RNG state initialization #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/dwgsim_opt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,8 +382,16 @@ dwgsim_opt_parse(dwgsim_opt_t *opt, int argc, char *argv[])
break;
}

// random seed
srand48((-1 == opt->seed) ? time(0) : opt->seed);
// random seed - use seed48() for full 48-bit state initialization
// This matches srand48() behavior: X_i = (seedval << 16) + 0x330E
{
unsigned short xseed[3];
long seed_val = (-1 == opt->seed) ? time(0) : opt->seed;
xseed[0] = 0x330e; // low-order 16 bits (standard value)
xseed[1] = seed_val & 0xffff; // middle 16 bits
xseed[2] = (seed_val >> 16) & 0xffff; // high-order 16 bits
seed48(xseed);
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

if(IONTORRENT == opt->data_type) {
if(NULL != opt->flow_order) {
Expand Down