fix: handle N base in bit-packed insertion encoding#109
Conversation
When nst_nt4_table returns 4 (for 'N' or unknown bases), the bit shift can cause unexpected behavior: 1. In short insertions (line 318): value 4 encoded into 2-bit field 2. In long insertions (line 350): value 4 shifted by 0-6 bits can overflow uint8_t when bit_index=3 (4 << 6 = 256) Fix: Check if base lookup returns >= 4 and substitute a random base, consistent with the behavior when bases parameter is NULL. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Warning Rate limit exceeded@nh13 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 26 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
Fixes #108
Test plan
make test-unit)make test-integration)🤖 Generated with Claude Code