This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Update AndroidManifest.xml#374
Open
mihaicristianpetrescu wants to merge 1 commit intonhaarman:masterfrom
Open
Conversation
Removed android:allowBackup="true" because it forces the Android Project I'm working on to also use it otherwise it will throw a Manifest Merger conflict.
|
This is giving me errors as well. Is it needed on the library? |
Author
|
From my point of view it's not needed, I think it's just there as a default. |
|
Whats that status of this @nhaarman can we get a merge? Any reason for the backups? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed android:allowBackup="true" because it forces the Android Project I'm working on to also use it otherwise it will throw a Manifest Merger conflict.