feat: support .net 6 DateOnly TimeOnly structs#84
Open
pdevito3 wants to merge 1 commit intonickdodd79:masterfrom
Open
feat: support .net 6 DateOnly TimeOnly structs#84pdevito3 wants to merge 1 commit intonickdodd79:masterfrom
pdevito3 wants to merge 1 commit intonickdodd79:masterfrom
Conversation
pdevito3
commented
Apr 30, 2022
| entity2.Name.Should().Be(entity1.Name); | ||
| entity2.DeprecationDate.Should().BeCloseTo(entity1.DeprecationDate, 500); | ||
| entity2.Name.Should().Be(entity1.Name); | ||
| entity2.DeprecationDate.Should().BeCloseTo(entity1.DeprecationDate, TimeSpan.FromMilliseconds(500)); |
pdevito3
commented
Apr 30, 2022
| options => options | ||
| .Using<string>(context => context.Subject.Should().NotBeNull()) | ||
| .When(info => info.SelectedMemberPath == "Status") | ||
| .When(info => info.Path.Contains("Status")) |
pdevito3
commented
Apr 30, 2022
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="FluentAssertions" Version="5.10.3" /> | ||
| <PackageReference Include="FluentAssertions" Version="6.6.0" /> |
Author
There was a problem hiding this comment.
needed to update FA to accommodate the dateonly timeonly handling
|
this looks like a great feature! polite bump @nickdodd79 |
Author
|
I don't think he's maintaining the lib anymore. I made a fork that can handle this if you want to use it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #76
tried to follow your pattern throughout and included a test for the new type. I did have to do some minor update fluent assertion updates as well.
let me know if you have any questions or concerns!