Skip to content

Migrate absolute units to relative ones#38

Open
nicocadq wants to merge 1 commit intodevelopfrom
feature/migrate-styles-units
Open

Migrate absolute units to relative ones#38
nicocadq wants to merge 1 commit intodevelopfrom
feature/migrate-styles-units

Conversation

@nicocadq
Copy link
Owner

@nicocadq nicocadq commented Dec 1, 2020

Migrate absolute units to relative ones

@@ -0,0 +1 @@
[{"/Users/nicolas/Desktop/loopcommerce/src/components/Signup/Signup.styles.js":"1","/Users/nicolas/Desktop/loopcommerce/src/components/Login/Login.styles.js":"2","/Users/nicolas/Desktop/loopcommerce/src/components/Header/Header.styles.js":"3","/Users/nicolas/Desktop/loopcommerce/src/components/ServiceCard/ServiceCard.styles.js":"4"},{"size":1204,"mtime":1606834976334,"results":"5","hashOfConfig":"6"},{"size":1219,"mtime":1606834957022,"results":"7","hashOfConfig":"6"},{"size":1976,"mtime":1606835127674,"results":"8","hashOfConfig":"6"},{"size":950,"mtime":1606835297105,"results":"9","hashOfConfig":"6"},{"filePath":"10","messages":"11","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"tmtx83",{"filePath":"12","messages":"13","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"14","messages":"15","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"16","messages":"17","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"/Users/nicolas/Desktop/loopcommerce/src/components/Signup/Signup.styles.js",[],"/Users/nicolas/Desktop/loopcommerce/src/components/Login/Login.styles.js",[],"/Users/nicolas/Desktop/loopcommerce/src/components/Header/Header.styles.js",[],"/Users/nicolas/Desktop/loopcommerce/src/components/ServiceCard/ServiceCard.styles.js",[]] No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add this file to the .gitignore

border: 1px solid ${({ theme: { colors } }) => colors.scaleGray3};
border-radius: ${({ theme: { border } }) => border.radius.xs} 0 0
border: 0.1rem solid ${({ theme: { colors } }) => colors.scaleGray3};
border-radius: ${({ theme: { border } }) => border.radius.xs} 0rem 0rem
Copy link
Collaborator

@eleleiva eleleiva Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being the previous value just 0 I don't see why don't stick to that.

Base automatically changed from feature/migrate-styles to develop December 9, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants