Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
tjholm
commented
Oct 7, 2025
| } | ||
|
|
||
| func (td *TerraformDeployment) createOutputsForModule(name string, module cdktf.TerraformHclModule) { | ||
| cdktf.NewTerraformOutput(td.stack, jsii.Sprintf("%s_outputs", name), &cdktf.TerraformOutputConfig{ |
Member
Author
There was a problem hiding this comment.
Currently outputs are scoped to <resource_name>_outputs, but this can possibly just be resource_name?
Member
There was a problem hiding this comment.
I think the _outputs is redundant and most modules and examples don't use it.
tjholm
force-pushed
the
default-outputs
branch
from
5a6f269 to
debdd1d
Compare
tjholm
force-pushed
the
default-outputs
branch
from
debdd1d to
08808a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds outputs that default to terraform module outputs
Fixes: NIT-378
If plugins are missing outputs they simply need to be added to the terraform outputs.