Updated the handling of gridded data in loading and formatting model data#392
Open
Paul-Carvalho wants to merge 5 commits into
Open
Updated the handling of gridded data in loading and formatting model data#392Paul-Carvalho wants to merge 5 commits into
Paul-Carvalho wants to merge 5 commits into
Conversation
…prevent join explosion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces several stability and compatibility improvements to the
format_model_datafunction. The primary focus is on expanding gridded data capabilities, preventing Cartesian "join explosions" during temporal data merges, and smoothing out integration with the Shiny GUI.Key Changes
imputeArgument: Wrapped theimputeinput intolower()prior to the validation checks. This ensures that capitalized inputs passed directly from the GUI dropdowns (e.g., "Mean" or "Median") are handled seamlessly without throwing an error.Dateclasses, Unix timestamps, and string names).select_vars). This prevents catastrophic Cartesian join explosions.Dateclass before executing theleft_join.Testing
format_model_datacover these operational updates and pass successfully without requiring any modifications.Associated issues