Skip to content

go 1.25 update dependencies#57

Merged
noborus merged 1 commit intomasterfrom
go125
Mar 4, 2026
Merged

go 1.25 update dependencies#57
noborus merged 1 commit intomasterfrom
go125

Conversation

@noborus
Copy link
Copy Markdown
Owner

@noborus noborus commented Mar 4, 2026

Summary by CodeRabbit

  • Chores
    • Updated Go version to 1.25.0 and modernized build tag syntax across platform-specific files.
    • Updated project dependencies to their latest versions.
    • Refactored internal variable declarations for improved code structure.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 4, 2026

📝 Walkthrough

Walkthrough

The changes modernize Go build constraints by removing legacy // +build syntax tags across multiple files, update the Go version from 1.24.0 to 1.25.0 in go.mod with multiple indirect dependency updates, and refactor a variable declaration in cmd/root.go from a grouped var block to standalone.

Changes

Cohort / File(s) Summary
Build Constraint Modernization
process_linux.go, process_other.go, winservices_query.go
Removed legacy // +build tags while retaining //go:build directives, modernizing build constraint syntax to Go 1.17+ standard.
Module and Dependency Updates
go.mod
Updated Go directive from 1.24.0 to 1.25.0, removed toolchain line. Updated 15+ indirect dependencies including filippo.io/edwards25519, goccy/go-yaml, lib/pq, mattn/go-sqlite3, ncruces/go-strftime, modernc.org/sqlite, and golang.org/x packages. Added clipperhouse/uax29/v2 and golang.org/x/tools; removed golang.org/x/exp and riv o/uniseg.
Variable Declaration Refactor
cmd/root.go
Moved ErrNoQuery from grouped var block to standalone var declaration with no functional change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Build tags cleaned up, shiny and new,
Legacy syntax bid its adieu,
Dependencies bumped, versions align,
Go 1.25 makes everything fine,
A refactored var, neat and true!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'go 1.25 update dependencies' directly matches the main changes in the PR: upgrading Go from 1.24.0 to 1.25.0 and updating multiple indirect dependencies across go.mod.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch go125

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
go.mod (1)

12-55: Run a quick vulnerability sweep for the upgraded module graph.

The dependency refresh is broad; a pre-merge advisory check helps catch regressions early.

#!/bin/bash
set -euo pipefail

python - <<'PY'
import json, re, urllib.request

mods = []
with open("go.mod", "r", encoding="utf-8") as f:
    for line in f:
        m = re.match(r'^\s*([A-Za-z0-9._/\-]+)\s+(v[0-9][^\s]+)\s*(//.*)?$', line)
        if m:
            mods.append((m.group(1), m.group(2)))

findings = []
for name, version in mods:
    payload = json.dumps({
        "package": {"ecosystem": "Go", "name": name},
        "version": version
    }).encode("utf-8")
    req = urllib.request.Request(
        "https://api.osv.dev/v1/query",
        data=payload,
        headers={"Content-Type": "application/json"},
    )
    try:
        with urllib.request.urlopen(req, timeout=20) as r:
            resp = json.loads(r.read().decode("utf-8"))
    except Exception as e:
        print(f"ERROR querying {name}@{version}: {e}")
        continue

    vulns = resp.get("vulns", [])
    if vulns:
        findings.append((name, version, [v.get("id", "UNKNOWN") for v in vulns]))

if not findings:
    print("No OSV advisories returned for dependencies in go.mod.")
else:
    print("Potential advisories found:")
    for name, version, ids in findings:
        print(f"- {name}@{version}: {', '.join(ids)}")
PY
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Line 3: Update the GitHub Actions workflows to pin the Go version to 1.25 to
match go.mod (go 1.25.0). In release.yml replace the go-version entry currently
set to 'stable' with '1.25' (search for the go-version key in release.yml), and
in test.yml update the matrix configuration to include '1.25' instead of any
floating values like 'stable' or 'oldstable' (search for matrix.go-version or
matrix entries in test.yml). Ensure both workflows consistently reference "1.25"
so CI and releases use the same minimum Go version.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ad8dee62-8edf-4256-a9f8-32d946e1cde8

📥 Commits

Reviewing files that changed from the base of the PR and between fe4107d and cea71c6.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (5)
  • cmd/root.go
  • go.mod
  • process_linux.go
  • process_other.go
  • winservices_query.go
💤 Files with no reviewable changes (3)
  • winservices_query.go
  • process_linux.go
  • process_other.go

Comment thread go.mod
go 1.24.0

toolchain go1.24.2
go 1.25.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

if [ -d ".github/workflows" ]; then
  rg -nH -C2 'setup-go|go-version|golang' .github/workflows
else
  echo "No .github/workflows directory found."
fi

Repository: noborus/psutilsql

Length of output: 1171


Pin CI/release workflows to Go 1.25.x to match go.mod requirement.

The workflows currently use floating versions ('stable' and 'oldstable'), which can drift from the minimum Go version specified in go.mod. Update:

  • release.yml line 17: Change go-version: 'stable' to go-version: '1.25'
  • test.yml line 8: Change matrix to include '1.25' instead of floating references
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` at line 3, Update the GitHub Actions workflows to pin the Go version
to 1.25 to match go.mod (go 1.25.0). In release.yml replace the go-version entry
currently set to 'stable' with '1.25' (search for the go-version key in
release.yml), and in test.yml update the matrix configuration to include '1.25'
instead of any floating values like 'stable' or 'oldstable' (search for
matrix.go-version or matrix entries in test.yml). Ensure both workflows
consistently reference "1.25" so CI and releases use the same minimum Go
version.

@noborus noborus merged commit 113ecb0 into master Mar 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant