Skip to content

Conversation

@nagaozen
Copy link
Contributor

Though createTable handles tableName with it's schema, hasTable does not and requires calling withSchema when tableName contains the prefixed schema.

Though `createTable` handles tableName with it's schema, `hasTable` does not and requires calling `withSchema` when `tableName` contains the prefixed schema.
@hsluoyz
Copy link
Member

hsluoyz commented Feb 14, 2025

@nodece @Shivansh-yadav13 please review

@hsluoyz
Copy link
Member

hsluoyz commented Feb 15, 2025

@nagaozen fix all CIs:

image

@nagaozen
Copy link
Contributor Author

@hsluoyz, I finally made it all pass =D

@hsluoyz hsluoyz changed the title fix: allow tableName to contain schema feat: allow tableName to contain schema Feb 16, 2025
@hsluoyz hsluoyz merged commit f715096 into node-casbin:master Feb 21, 2025
8 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 21, 2025
# [1.3.0](v1.2.0...v1.3.0) (2025-02-21)

### Features

* allow `tableName ` to contain schema ([#31](#31)) ([f715096](f715096))
@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nagaozen nagaozen deleted the fix/schemaDotTable branch March 24, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants