-
Notifications
You must be signed in to change notification settings - Fork 9
feat: allow tableName to contain schema
#31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though `createTable` handles tableName with it's schema, `hasTable` does not and requires calling `withSchema` when `tableName` contains the prefixed schema.
Member
|
@nodece @Shivansh-yadav13 please review |
Member
|
@nagaozen fix all CIs: |
Contributor
Author
|
@hsluoyz, I finally made it all pass =D |
tableName to contain schematableName to contain schema
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
# [1.3.0](v1.2.0...v1.3.0) (2025-02-21) ### Features * allow `tableName ` to contain schema ([#31](#31)) ([f715096](f715096))
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Though
createTablehandles tableName with it's schema,hasTabledoes not and requires callingwithSchemawhentableNamecontains the prefixed schema.