Skip to content

Conversation

@canerakdas
Copy link
Member

Description

This PR is dependent on nodejs/nodejs.org#8523

Related Issues

depends on nodejs/nodejs.org#8523,

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings January 7, 2026 17:38
@canerakdas canerakdas requested a review from a team as a code owner January 7, 2026 17:38
@vercel
Copy link

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
api-docs-tooling Ready Ready Preview Jan 8, 2026 6:33am

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.97%. Comparing base (2cff615) to head (eb7f606).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   79.97%   79.97%           
=======================================
  Files         127      127           
  Lines       12276    12276           
  Branches      866      866           
=======================================
  Hits         9818     9818           
  Misses       2455     2455           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes search modal overflow issues by removing local CSS overrides and upgrading the @node-core/ui-components package from version 1.5.2 to 1.5.3, which presumably includes the overflow fix internally.

Key Changes:

  • Removes CSS rules targeting #modalContent for handling overflow in search modal links
  • Updates @node-core/ui-components dependency to version 1.5.3

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/generators/web/ui/index.css Removes 18 lines of CSS that handled overflow, text truncation, and flex shrinking for modal content links
package.json Updates @node-core/ui-components from version 1.5.2 to 1.5.3 to incorporate upstream overflow fixes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@canerakdas canerakdas marked this pull request as draft January 7, 2026 17:49
@canerakdas canerakdas marked this pull request as ready for review January 8, 2026 06:34
@avivkeller avivkeller merged commit 39b2c0f into nodejs:main Jan 8, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants