-
Notifications
You must be signed in to change notification settings - Fork 24
fix: search modal overflow #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 79.97% 79.97%
=======================================
Files 127 127
Lines 12276 12276
Branches 866 866
=======================================
Hits 9818 9818
Misses 2455 2455
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes search modal overflow issues by removing local CSS overrides and upgrading the @node-core/ui-components package from version 1.5.2 to 1.5.3, which presumably includes the overflow fix internally.
Key Changes:
- Removes CSS rules targeting
#modalContentfor handling overflow in search modal links - Updates
@node-core/ui-componentsdependency to version 1.5.3
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/generators/web/ui/index.css | Removes 18 lines of CSS that handled overflow, text truncation, and flex shrinking for modal content links |
| package.json | Updates @node-core/ui-components from version 1.5.2 to 1.5.3 to incorporate upstream overflow fixes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
This PR is dependent on nodejs/nodejs.org#8523
Related Issues
depends on nodejs/nodejs.org#8523,
Check List
node --run testand all tests passed.node --run format&node --run lint.