util: limit inspect to only show own properties #61032
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error's cause and errors properties would be visible even if these were not own properties. This is changed to align with all other parts of the inspect handling. As drive-by I changed an array to a set for faster lookup in assert. Fixes: nodejs#60717 Closes: nodejs#60724
BridgeAR
added
util
nodejs-github-bot
added
assert
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61032 +/- ##
==========================================
- Coverage 88.52% 88.52% -0.01%
==========================================
Files 703 703
Lines 208538 208539 +1
Branches 40214 40220 +6
==========================================
- Hits 184615 184611 -4
- Misses 15921 15950 +29
+ Partials 8002 7978 -24
🚀 New features to boost your workflow:
|
ljharb
approved these changes
Dec 12, 2025
BridgeAR
added
author ready
aduh95
reviewed
Dec 12, 2025
| const kMaxLongStringLength = 512; | ||
|
|
||
| const kMethodsWithCustomMessageDiff = ['deepStrictEqual', 'strictEqual', 'partialDeepStrictEqual']; | ||
| const kMethodsWithCustomMessageDiff = new SafeSet(['deepStrictEqual', 'strictEqual', 'partialDeepStrictEqual']); |
Contributor
There was a problem hiding this comment.
It should its own PR IMO, as is it makes the git blame harder to use, and so it can be reverted / benchmarked on its own if need be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error's cause and errors properties would be visible even if these were not own properties. This is changed to align with all other parts of the inspect handling.
As drive-by I changed an array to a set for faster lookup in assert.
Fixes: #60717
Closes: #60724