Skip to content

Conversation

@rubnogueira
Copy link

fix: #61222

Using Chrome DevTools inspector tool, the response of the compressed requests is full of garbled symbols.

This PR implements proper compression decryption if the content-encoding header is returned in the response headers.

Repro here: https://github.com/rubnogueira/nodejs-repro-61222

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/inspector

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Dec 30, 2025
@rubnogueira
Copy link
Author

Tagging you @legendecas because I saw some of your work on the inspector.

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 84.13462% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.54%. Comparing base (ce2ec3d) to head (2a5c76c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/inspector/network.js 61.33% 29 Missing ⚠️
lib/internal/inspector/network_http.js 97.01% 2 Missing ⚠️
lib/internal/inspector/network_http2.js 96.96% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61226      +/-   ##
==========================================
- Coverage   88.54%   88.54%   -0.01%     
==========================================
  Files         704      704              
  Lines      208734   208907     +173     
  Branches    40271    40292      +21     
==========================================
+ Hits       184823   184975     +152     
- Misses      15932    15962      +30     
+ Partials     7979     7970       -9     
Files with missing lines Coverage Δ
lib/internal/inspector/network_http.js 95.45% <97.01%> (+0.18%) ⬆️
lib/internal/inspector/network_http2.js 88.99% <96.96%> (+1.25%) ⬆️
lib/internal/inspector/network.js 81.03% <61.33%> (-14.93%) ⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rubnogueira rubnogueira changed the title fix: zipped responses inspector: fix compressed responses Dec 31, 2025
@rubnogueira
Copy link
Author

I just removed irrelevant code, improved testing/linting, built locally Node binary, and tested against my repro. Rebased first commit message following guidelines.

Please let me know if something is missing since it's my first contribution in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http2 Issues or PRs related to the http2 subsystem. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--experimental-network-inspection not working properly with gzip, br, zstd and response

2 participants