test: forbid use of named imports for fixtures #61228
Open
+164
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
addons
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61228 +/- ##
==========================================
- Coverage 88.54% 88.53% -0.02%
==========================================
Files 704 704
Lines 208738 208738
Branches 40278 40273 -5
==========================================
- Hits 184833 184806 -27
- Misses 15914 15952 +38
+ Partials 7991 7980 -11 🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Dec 31, 2025
lpinca
approved these changes
Dec 31, 2025
Renegade334
approved these changes
Dec 31, 2025
| selector: `:not(VariableDeclarator[id.type="Identifier"])>CallExpression[callee.name="require"][arguments.0.value=${fixturesSpecifier}]`, | ||
| message: 'Do not destructure, use `const fixtures =` instead', | ||
| }, | ||
| ])(/^(\.\.\u002f)+common\u002ffixtures(\.js)?$/), |
Member
There was a problem hiding this comment.
Is it worth passing a RegExp literal just to repeatedly stringify it? Would it be easier just to pass a string literal here?
Comment on lines
-10
to
+11
| return path.join(fixturesDir, ...args); | ||
| args.unshift(fixturesDir); | ||
| return Reflect.apply(path.join, this, args); |
Member
There was a problem hiding this comment.
Just curious - what's the benefit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
import { path } from '../common/fixtures.mjsresults inpathto refer to a function, which is confusing as it more often refers tonode:path. In general, most utils of this module benefits from being prefixed withfixtures.(i.e.fileURL(…)vsfixtures.fileURL(…)).Refs: #61089 (comment)