tools: add tool that fills pr-url as code review suggestion
#61247
+113
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
meta
aduh95
reviewed
Jan 1, 2026
aduh95
reviewed
Jan 1, 2026
Comment on lines
28
to
29
| REPO: ${{ github.repository }} | ||
| SHA: ${{ github.sha }} |
Contributor
There was a problem hiding this comment.
We can use $GITHUB_REPOSITORY and $GITHUB_SHA that are already defined (see https://docs.github.com/en/actions/reference/workflows-and-actions/variables#default-environment-variables)
aduh95
reviewed
Jan 1, 2026
tools/actions/suggest-fill-prurl.mjs
Outdated
|
|
||
| // https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#create-a-review-for-a-pull-request | ||
| await fetch( | ||
| new URL(`repos/${REPO}/pulls/${PR_NUMBER}/reviews`, 'https://api.github.com'), |
Contributor
There was a problem hiding this comment.
Suggested change
| new URL(`repos/${REPO}/pulls/${PR_NUMBER}/reviews`, 'https://api.github.com'), | |
| new URL(`repos/${REPO}/pulls/${PR_NUMBER}/reviews`, process.env.GITHUB_API_URL || 'https://api.github.com'), |
Renegade334
reviewed
Jan 1, 2026
Comment on lines
27
to
30
| const res = await fetch( | ||
| new URL(`repos/${REPO}/pulls/${PR_NUMBER}/files`, 'https://api.github.com'), | ||
| { headers }, | ||
| ); |
Member
There was a problem hiding this comment.
Would it be better to use octokit here, rather than manually interacting with the API?
Member
Author
There was a problem hiding this comment.
I'm fine with either way, by default manual requests should have slightly less overhead. Are there benefits from using octikit here?
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to fill
pr-urlin docs is sometimes annoying, since there's no guaranteed way to predict the PR number before pushing the changes.This PR adds tool that searches for
https://github.com/nodejs/node/pull/FILLMEand postshttps://github.com/nodejs/node/pull/12345(where12345is actual PR number) as code review suggestion (```suggestion).To avoid unnecessary flooding, it triggers only on initial open, and only if pr-url was explicitly set as
https://github.com/nodejs/node/pull/FILLMEin the files.This also could be addressed as local tool, or even as ncu feature (e.g.
git node i-feel-luckyto guess the next number, fill and commit).