test_runner: add skip, todo, only to subtest context #61251
+88
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Member
|
Can you please add tests? |
The test context passed to subtests was missing the `.skip`, `.todo`, and `.only` variants on `t.test`. These were available on the top-level `test` function but not on the subtest context. Move the test function from a class method to an arrow function in the constructor so that `.skip`, `.todo`, and `.only` properties can be attached to it. Fixes: nodejs#50665
heathdutton
force-pushed
the
test_runner/fix-subtest-skip-only-todo-50665
branch
from
c87fc54 to
f8775f9
Compare
Author
|
Added test file: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test context passed to subtests was missing the
.skip,.todo,and
.onlyvariants ont.test. These were available on the top-leveltestfunction but not on the subtest context.Move the test function from a class method to an arrow function in
the constructor so that
.skip,.todo, and.onlyproperties canbe attached to it.
Fixes: #50665