test_runner: capture process state in entry point instead of runner#64446
Open
krsnaSuraj wants to merge 1 commit into
Open
test_runner: capture process state in entry point instead of runner#64446krsnaSuraj wants to merge 1 commit into
krsnaSuraj wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
f12fe6e to
b533d0d
Compare
Move process.* reads (process.argv, process.env, process.cwd) from runner.js to the CLI entry point (main/test_runner.js), so that runner.js can be loaded without side effects in snapshot environments. The execArgv case is handled via a fallback in getRunArgs(): when no execArgv is passed in options, process.execArgv is still read directly to propagate V8-only flags to child processes. PR-URL: https://github.com/nodejs/node/pull/XXXXX Refs: nodejs#56131
b533d0d to
6b2cb24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #53867.
The run() function in the test runner directly accesses process.execArgv to find V8-only flags like --expose-gc that need propagation to child processes. This is problematic because run() is part of the public API exposed to end users via node:test and should not depend on ambient process state.
This PR moves those reads to the CLI entry point (test_runner.js) and passes them as explicit options to run():
This ensures that: