Adding System.Collections.Immutable into the mix#1
Open
SamuelBerger wants to merge 2 commits intonojaf:mainfrom
Open
Adding System.Collections.Immutable into the mix#1SamuelBerger wants to merge 2 commits intonojaf:mainfrom
SamuelBerger wants to merge 2 commits intonojaf:mainfrom
Conversation
Owner
|
Hi Sam, I've changed my struct to a class in my production code instead. |
Author
|
I see :) |
Owner
|
Out of curiosity, where can you download |
Author
|
Installing latest Visual Studio preview. I use Rider and VS remains only an SDK installer for me :) |
Owner
|
You could also try the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Florian,
We are also hit by the "Could not load type 'System.Runtime.CompilerServices.IsReadOnlyAttribute' from assembly System.Collections.Immutable ..." when trying to upgrade to .NET 7.
I observed, that the System.Runtime.CompilerServices.IsReadOnlyAttribute is emitted to F# struct only when System.Collections.Immutable package is referenced in the project.
I have tried to build with the latest preview 7.0.200-preview.22628.1 as well, same result. But I am not sure, if the fix is already included there.
You've said I was able to compile my [repro] with the local compiler and the test now passes.
Could you try it again with this PR?
Cheers sam