Add detect_encoding() function and adapt docs#2
Open
nalimilan wants to merge 3 commits intonolta:masterfrom
Open
Add detect_encoding() function and adapt docs#2nalimilan wants to merge 3 commits intonolta:masterfrom
nalimilan wants to merge 3 commits intonolta:masterfrom
Conversation
Author
|
I've added a commit fixing deprecation warnings. I could make a separate PR, but since they conflict... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on JuliaStrings/ICU.jl#9.
I had to cheat a little in the examples because with only the first word encoding detection was really poor, which would have been quite ridiculous. OTOH it's pretty good with just a few more words, and the typical use case is more about large files.