hotfix/improve-theme#56
Conversation
pieeri
added
⚠️ WIP
|
Nice restyling @TheTimb, overall it looks more modern, specially the components and tabs. Only thing I am not a fan and find a bit visually polluting is the drop shadow on the left of the card and table: 
In the components the yellow line is used to highlight the component when it is in focus (which is fine and looks good), but here (in the card and table) is can mislead the user into thinking the component is somehow selected. |
TheTimb
force-pushed
the
hotfix/improve-theme
branch
from
9bd43c5 to
509bf24
Compare
TheTimb
force-pushed
the
hotfix/improve-theme
branch
from
509bf24 to
e705bc8
Compare
Good point, I use a grey now. |
filiperosa
left a comment
filiperosa
left a comment
There was a problem hiding this comment.
👍
Looks good to me. We just need to bump the version and write down the changes for release.
|
|
||
| [project] | ||
| name = "dash-material-components" | ||
| version = "2.2.0" |
There was a problem hiding this comment.
🚢
We need to bump the version to release, here and in the package.json, and also update the CHANGELOG with a summary of all the changes.
| version = "2.2.1" |
| "type": "git", | ||
| "url": "git://github.com/noosenergy/dash-material-components.git" | ||
| }, | ||
| "version": "2.2.0", |
There was a problem hiding this comment.
♻️
| "version": "2.2.1", |
There was a problem hiding this comment.
♻️
- Changelogs as per checklist on the PR description.
| ); | ||
| }); | ||
|
|
||
| // Configure menu controls |
There was a problem hiding this comment.
❓
Maybe a LLM breadcrumb for removing such a constant?
There was a problem hiding this comment.
🐼
I find the component styling performed by the agent is hard to follow, with styling components located inside the components itself (rather as constants on top of file).
| }: { | ||
| children: JSX.Element; | ||
| theme: Partial<Theme>; | ||
| theme: Record<string, unknown>; |
There was a problem hiding this comment.
❓
Can't the type Theme be imported directly from @mui/material/styles?
pieeri
added
🚢 Ready to ship
3 participants
Description
Improve overall theme with tuning of Mui component
Improve Table component with sticky first line and column
Create new component: CsUploader
Create enedis parsers in javascript with tests
Create test notebook for the csv uploader
JIRA Reference: NOOS-
Checklist
pyproject.tomlandpackage.jsonCHANGELOG.md