Workflow permissions per Scorecard recommendations#87
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates workflow permissions to comply with Scorecard recommendations by reducing global permissions and elevating permissions only for specific jobs.
- Global "contents" permission is changed from write to read in the workflows
- Job-level permissions remain set to write for required actions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/versioning.yml | Global permissions updated (contents set to read) and job-level permissions set explicitly |
| .github/workflows/release.yml | Global permissions updated (contents set to read) and job-level permissions set explicitly |
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| contents: read |
There was a problem hiding this comment.
The global permissions block is mixing list item syntax with mapping syntax. Consider unifying the format (preferably using mapping syntax) to avoid potential YAML parsing or misconfiguration issues.
|
|
||
| permissions: | ||
| contents: write | ||
| contents: read |
There was a problem hiding this comment.
The global permissions block uses mixed syntaxes, which could lead to configuration issues. Please refactor to a consistent mapping format for clarity and reliability.
Suggested change
| contents: read | |
| contents: | |
| read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.