Build SAP CC agent toolkit plugin with 10 skills#1
Merged
Conversation
Researched the AWS agent-toolkit-for-aws reference architecture and mapped it to our openstack-mcp-server's 9 services / 28+ tools. Key decisions: - Single plugin (sapcc) since all services are always needed - 10 skills with progressive disclosure (load on demand) - Gotchas sections as primary value-add (prevent agent mistakes) - tools/validate.py for CI enforcement of skill format
Plugin structure following AWS agent-toolkit-for-aws pattern: - Single 'sapcc' plugin with .mcp.json and .claude-plugin manifest - Marketplace manifest for /plugin install support Skills (10 total, all passing validation): - sapcc-compute: Nova server lifecycle, flavor selection, gotchas - sapcc-networking: Neutron topology, security groups, debugging - sapcc-storage: Cinder volume lifecycle, attachment states - sapcc-identity: Keystone domain/project model, app credentials - sapcc-quota: Limes quota interpretation (13 gotchas) - sapcc-audit: Hermes CADF events, compliance workflows - sapcc-metrics: Maia PromQL, metric discovery - sapcc-registry: Keppel container images, federation - sapcc-connectivity: Archer private endpoint services - credential-setup: Guided auth setup with keychain storage Each skill follows philosophy: dense text, workflow-first, gotchas as primary value-add, progressive disclosure via references/. Also includes: - rules/sapcc-agent-rules.md (baseline agent behavior) - knowledge/sapcc/architecture.md (regional model, domain hierarchy) - knowledge/sapcc/troubleshooting-flows.md (cross-service debugging) - tools/validate.py (CI validation, stdlib-only) Old skills/ directory removed (superseded by plugins/sapcc/skills/).
- Replace nova_show_server with nova_get_server in sapcc-networking (3 occurrences — the MCP server exposes nova_get_server, not nova_show_server) - Normalize version: 1 → version: 1.0.0 in sapcc-audit, sapcc-compute, sapcc-identity for consistency with other skills
Skills: - Add metadata fields to 5 skills missing them (connectivity, metrics, quota, registry, storage) - Remove useless allowed-tools: [Read] from audit, compute, identity - Add Cross-Service References tables to compute, audit, quota, storage, metrics - Add Routing tables (AWS pattern) to all skills with references Infrastructure: - Add GitHub Actions CI (.github/workflows/validate.yml) - Add .agents/plugins/marketplace.json (Codex/agents format) - Add .codex-plugin/plugin.json for sapcc plugin - Add .editorconfig matching sapcc org conventions (SPDX header) - Add .github/CODEOWNERS (@notque) - Add CODE_OF_CONDUCT.md (SAP standard, Contributor Covenant 2.1) - Add LICENSE and LICENSES/Apache-2.0.txt (REUSE compliance) Validator: - Fix KEBAB_RE to allow single-char first segments - Add .agents marketplace validation - Add .codex-plugin/plugin.json validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sapccplugin with 10 domain-specific skills covering all 9 MCP server servicesWhat's Included
Plugin Infrastructure
.claude-plugin/marketplace.json— Plugin registry for/plugin installplugins/sapcc/.mcp.json— MCP server configurationplugins/sapcc/.claude-plugin/plugin.json— Plugin metadatarules/sapcc-agent-rules.md— Baseline agent behavior rulestools/validate.py— CI validation (stdlib-only, all skills passing)Skills (10)
Knowledge
knowledge/sapcc/architecture.md— Regional model, domain hierarchyknowledge/sapcc/troubleshooting-flows.md— Cross-service debugging patternsADR
See
docs/adr/001-toolkit-architecture.mdfor the full architecture decision record.Test plan
python3 tools/validate.pypasses (all manifests + skills valid)/plugin install sapcc@openstack-agent-toolkitin Claude Code