Skip to content

Update generated client from staging OpenAPI#41

Merged
leo-notte merged 1 commit into
mainfrom
release-check-openapi-secrets
May 20, 2026
Merged

Update generated client from staging OpenAPI#41
leo-notte merged 1 commit into
mainfrom
release-check-openapi-secrets

Conversation

@leo-notte
Copy link
Copy Markdown
Contributor

Summary

  • regenerate the Go API client from the current staging OpenAPI spec
  • includes the new secrets API surface in generated client code

Test plan

  • make check
  • go test -short ./...

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 20, 2026

Greptile Summary

This PR regenerates internal/api/client.gen.go from the staging OpenAPI spec to add a new Secrets API surface alongside the existing session and browser-automation endpoints.

  • Adds four new operations — ListSecrets, StoreSecret, GetSecret, DeleteSecret — with full request builders, response parsers, result types, and a SecretNamespace enum (function_env, llm_provider).
  • Existing session-management request builders are reordered in the file but their logic is unchanged.

Confidence Score: 5/5

The change is a mechanical code-generation update that follows established patterns and does not touch existing logic.

All changes are auto-generated from an OpenAPI spec and mirror the established patterns for request builders, response parsers, and result types throughout the file. No hand-written logic was modified and no existing call sites are affected.

No files require special attention beyond the minor spec-level inconsistency in SecretMetadata.LastUsedAt typing.

Important Files Changed

Filename Overview
internal/api/client.gen.go Regenerated Go client adds full Secrets CRUD surface including new types, request builders, result parsers, and interface methods; minor spec inconsistency in LastUsedAt typing and no accompanying tests.

Fix All in Claude Code

Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
internal/api/client.gen.go:2143
**`LastUsedAt` typed as `*string` instead of `*time.Time`**

`SecretMetadata.CreatedAt` is `time.Time`, but `LastUsedAt` is `*string`. If the server ever returns a timestamp here, callers will have to manually parse it — unlike every other timestamp field in the file. This looks like an inconsistency in the OpenAPI spec that leaked into the generated client; worth aligning the spec so the generator emits `*time.Time` here.

### Issue 2 of 2
internal/api/client.gen.go:8404-8423
**No tests added for new Secrets API surface**

This PR introduces four new API operations (`ListSecrets`, `StoreSecret`, `GetSecret`, `DeleteSecret`) but includes no unit or integration tests. Per the project's test guidelines, at least one integration test should accompany a major feature addition like a new API surface.
- Add a comment if the PR does n... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))

Reviews (2): Last reviewed commit: "Update generated client from staging Ope..." | Re-trigger Greptile

@leo-notte leo-notte merged commit 1a43ea7 into main May 20, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant