Update generated client from staging OpenAPI#41
Merged
Conversation
|
| Filename | Overview |
|---|---|
| internal/api/client.gen.go | Regenerated Go client adds full Secrets CRUD surface including new types, request builders, result parsers, and interface methods; minor spec inconsistency in LastUsedAt typing and no accompanying tests. |
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
internal/api/client.gen.go:2143
**`LastUsedAt` typed as `*string` instead of `*time.Time`**
`SecretMetadata.CreatedAt` is `time.Time`, but `LastUsedAt` is `*string`. If the server ever returns a timestamp here, callers will have to manually parse it — unlike every other timestamp field in the file. This looks like an inconsistency in the OpenAPI spec that leaked into the generated client; worth aligning the spec so the generator emits `*time.Time` here.
### Issue 2 of 2
internal/api/client.gen.go:8404-8423
**No tests added for new Secrets API surface**
This PR introduces four new API operations (`ListSecrets`, `StoreSecret`, `GetSecret`, `DeleteSecret`) but includes no unit or integration tests. Per the project's test guidelines, at least one integration test should accompany a major feature addition like a new API surface.
- Add a comment if the PR does n... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))
Reviews (2): Last reviewed commit: "Update generated client from staging Ope..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan