feat: add zero dependencies banner on the package page#2009
feat: add zero dependencies banner on the package page#2009floatDreamWithSong wants to merge 4 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThis pull request implements a feature to highlight packages with zero direct dependencies. It adds a new computed property to detect when a package lacks both dependencies and optional dependencies, rendering a new Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e2f4d65b-92fe-4fc1-a91c-285b03ab325b
📒 Files selected for processing (6)
app/components/Package/ZeroDirectDependencies.vueapp/pages/package/[[org]]/[name].vuei18n/locales/en.jsoni18n/locales/zh-CN.jsoni18n/schema.jsontest/nuxt/a11y.spec.ts
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7c6c96c9-b8f9-407a-8c7a-27b367234cc9
📒 Files selected for processing (4)
app/components/Package/ZeroDirectDependencies.vueapp/pages/package/[[org]]/[name].vuei18n/locales/en.jsoni18n/locales/zh-CN.json
🚧 Files skipped from review as they are similar to previous changes (3)
- i18n/locales/zh-CN.json
- app/components/Package/ZeroDirectDependencies.vue
- i18n/locales/en.json
| "has_replacement": "This dependency has suggested replacements", | ||
| "zero_dependencies": { | ||
| "title": "0 dependencies", | ||
| "description": "This package can help keep node_modules smaller and reduce the risk of upcoming security issues." |
There was a problem hiding this comment.
We want to make sure we get the wording right, so will share in the Discord to get some feedback 👀
🔗 Linked issue
Resolves #1900
🧭 Context
add
app/components/Package/ZeroDirectDependencies.vueas a banner, and correspond a11y test statement intest/nuxt/a11y.spec.ts📚 Description
highlight packages with 0 direct dependencies.
The intent is to show "this package will not balloon up the size of your node_modules", and also that 0 deps means reducing the risk of upcoming security issues.