Skip to content

fix: filter out security holding packages from algoria result #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shuuji3 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: filter out security holding packages from algoria result #2026

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0d8779
fix: filter out security holding packages from algoria result
shuuji3 Mar 10, 2026
78c7afb
chore: update code comment
shuuji3 Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/pages/search.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,21 @@ const { settings } = useSettings()

/**
* Reorder results to put exact package name match at the top,
* and optionally filter out platform-specific packages.
* and optionally filter out platform-specific packages or security holding packages.
*/
const visibleResults = computed(() => {
const raw = rawVisibleResults.value
if (!raw) return raw

let objects = raw.objects

// Filter out "Security holding package" package takendown by npm registory
objects = objects.filter(
r =>
r.package.version !== '0.0.1-security' ||
r.package.description !== 'security holding package',
)
Comment on lines +84 to +89
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Keep the result metadata in sync with this filter.

This only removes entries from objects; raw.total and the pagination state still describe the unfiltered provider response. That leaves the search count/live-region text overstated and can surface empty pages or redundant “load more” behaviour once these rows are stripped. This filter needs to happen where the search response metadata is produced, or the returned total/pagination metadata needs adjusting alongside objects.


// Filter out platform-specific packages if setting is enabled
if (settings.value.hidePlatformPackages) {
objects = objects.filter(r => !isPlatformSpecificPackage(r.package.name))
Expand Down
Loading