[FastAPI] Add request ID middleware for log correlation — Hermes Agent#1
Open
nporter-codes wants to merge 2 commits into
Open
[FastAPI] Add request ID middleware for log correlation — Hermes Agent#1nporter-codes wants to merge 2 commits into
nporter-codes wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
RequestIDMiddlewarefor FastAPI that generates a UUID request ID per request, stores it inrequest.state, echoes client-providedX-Request-IDheaders, and plumbs the ID into log records.Changes
fastapi/fastapi/middleware/request_id.pyRequestIDMiddleware— StarletteBaseHTTPMiddlewaresubclassRequestIDFilter— logging filter that injectsrequest_idinto every log recordrequest_id_context— module-level dict context for the filterfastapilogger at import timeAcceptance Criteria Covered
X-Request-IDresponse headerX-Request-IDis preserved and echoed backfinally)Agent Info