Skip to content

feat(qwik-ui): add EditableTextField and EditableSelectField components#96

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/add-editable-text-select-field
Draft

feat(qwik-ui): add EditableTextField and EditableSelectField components#96
Copilot wants to merge 2 commits into
mainfrom
copilot/add-editable-text-select-field

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 18, 2026

Adds two new inline-editable field components to qwik-ui for rendering a value in place with pencil/save/cancel controls.

Components

EditableTextField

  • View mode: value as text or <Link> (when isLink + href set) + pencil button
  • Edit mode: delegates to the existing TextField component + save/cancel icon buttons
  • rawValue pre-populates the input (useful when display value differs from editable value)

EditableSelectField

  • Same view/edit pattern; edit mode renders a DaisyUI <select> with options from selectOptions: Record<string, string> (value → display label)
  • rawValue sets the initially selected option key

Error handling

Both components track a local error signal. If onSave$ throws, the error message is shown inline and edit mode stays open. The external error prop handles pre-save validation errors from the parent; it surfaces when localError is empty.

Usage

<EditableTextField
  fieldName="displayName"
  value="Jane Doe"
  onSave$={async (v) => { await updateName(v); }}
  label="Display Name"
  isLink
  href="/users/jane"
/>

<EditableSelectField
  fieldName="status"
  value="Active"
  rawValue="active"
  selectOptions={{active: 'Active', inactive: 'Inactive', pending: 'Pending'}}
  onSave$={async (v) => { await updateStatus(v); }}
  label="Status"
/>

Both components are exported from the package root (src/index.ts).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cdn.jsdelivr.net
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/public/public/qwik-ui/node_modules/.bin/../vite/bin/vite.js build --mode lib (dns block)
  • eu.posthog.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/public/public/qwik-ui/node_modules/.bin/../vite/bin/vite.js build --mode lib (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: erikrj <365211+erikrj@users.noreply.github.com>
Copilot AI changed the title [WIP] Add EditableTextField and EditableSelectField components feat(qwik-ui): add EditableTextField and EditableSelectField components Mar 18, 2026
Copilot AI requested a review from erikrj March 18, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants