Copy parameter cell metadata to injected parameters cell#892
Open
paranoa233 wants to merge 1 commit into
Open
Conversation
ayushnandi718-dev
left a comment
There was a problem hiding this comment.
Good change. Preserving cell metadata (like slideshow type) from the original parameters cell is important for presentations. Verified the logic handles the edge case where no parameters cell exists. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parameterscell to the injected parameters cellparameterstag while preserving other metadata/tagsjupytermetadataFixes #731.
Tests
python -m pytest papermill/tests/test_parameterize.py -qpython -m pytest papermill/tests/test_parameterize.py papermill/tests/test_inspect.py papermill/tests/test_utils.py -qNote:
python -m pytest papermill/tests/test_execute.py -qpasses 25/26 locally; the remaining failure isTestBrokenNotebook2.test, where this minimal environment produces anerroroutput instead of the expecteddisplay_dataoutput for the fixture notebook. The failure is unrelated to parameter metadata handling.