feat: implement pointer fragment resolution#12
Merged
Conversation
Previously symbols were created only for properties (e.g. `/roles/engineering`). By moving the symbol creation on value nodes, we also index array elements (e.g. `roles/engineering/3`)
ntoulasm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Previously, the visitor only indexed property keys, which prevented navigation to specific array indices (e.g.,
"#/tags/2"). By refactoring indexing to valueNodes, the "Go To Definition" now jumps inside arrays too.Summary
This PR adds support for deep linking via URI fragments and refactors the
SymbolTablegeneration to save all JSON value types, including array elements.Key Changes
Array<Node>that stored only referenceNodes to aMap<string, JRefSymbol>where the key is a JSON Pointer.onDefinitionlogic to parse URI fragments and look up targets in theSymbolTableof this document.